alostsock / craftingway

A ffxiv crafting tool

Home Page:https://craftingway.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature Request: Macro Complete Sound

mindofbeholder opened this issue · comments

I've been spoiled by ffxivteamcraft.

Can you add a toggle to play a sound effect when a macro completes?
ffxivteamcraft example:
/echo Craft finished <se.1>

Thanks for making this an issue, much easier to track.

This is actually already implemented, but only if a rotation spills over into two parts (>15 steps).

I can add this for when a rotation is 14 steps or under, but if the macro is exactly 15 steps, should it still play a sound? Otherwise it will get split into two parts if the /echo is added.

Not a problem! I personally prefer to use issues when a project is github hosted :)

I'm using ffxivteamcraft as a reference point.

Their current behavior is that if the macro is 15 steps they drop the end sound, even if enabled.
If the macro is 16 steps they add the end sound back in and take the last two steps and push them into a second macro with the sound also enabled.

Should be fixed by 6a9c77f