alloy-rs / core

High-performance, well-tested & documented core libraries for Ethereum, in Rust

Home Page:https://www.paradigm.xyz/2023/06/alloy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Tests fail with solc versions <0.8.18

prestwich opened this issue · comments

Component

sol! macro, Other (please provide more details)

What version of Alloy are you on?

main

Operating System

macOS (Apple Silicon)

Describe the bug

Tests check the sol! acceptance of mapping(address a => uint256 b) but do not check that the installed solc is capable of handling that syntax. The named-key mapping syntax was introduces in 0.8.18. the run_solc() function in core/crates/syn-solidity/src/item/function.rs should check that the version is at least 0.8.18, rather than just checking for a solc bin