alliswell / Less

A simple minimal WordPress theme built with only what is needed to survive

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The .font-size mixin is broken.

randallbruder opened this issue · comments

The .font-size mixin (style.less, line 552) looks like this:

.font-size(@size){
    @rem-value: (@size / 10);
    @px-value: @size;
    @lineHeight: (@size * 1.48);
    line-height: @lineHeight+0px;
    font-size: ~"@{px-value}px"; 
    font-size: ~"@{rem-value}rem";
}

which, when compiled, causes the last two lines to look like this:

font-size: 10pxpx; 
font-size: 10pxrem;

because the @size being passed in contains a 'px'. It should be written this way:

.font-size(@size){
    @rem-value: (@size / 10);
    @px-value: @size;
    @lineHeight: (@size * 1.48);
    line-height: @lineHeight;
    font-size: unit(@px-value,px);
    font-size: unit(@rem-value,rem);
}