tagger_modules do not work in current git version
peterbjorgensen opened this issue · comments
Peter Bjørn Jørgensen commented
The modules show up with dolma list --tagger_modules mypackage.mymodule
but it crashes if you do dolma tag --tagger_modules mypackage.mymodule ...
The problem is that the tagger modules are not loaded before this part of the code which instantiates the taggers by name
dolma/python/dolma/core/runtime.py
Lines 428 to 433 in e7657e4
This means the dolma tag
commands crashes with ValueError: Unknown tagger mytagger ...
Luca Soldaini commented
Excellent catch!! fixed in main.