allenai / cached_path

I use cached_path for downloading executable dependencies. This works perfectly on Windows; on Linux however, some dependencies are only available as RPM files. Extracting those is not supported by cached_path yet.

The feature could be implemented using the rpmfile module. The following steps would be necessary for this:

Implement a function is_rpmfile that tries to parse the file and is missing from the rpm module linked above (that step could (should?) be done in the repo of the above module, which is available at https://github.com/srossross/rpmfile.
Use the is_rpmfile in the checks at

cached_path/cached_path/_cached_path.py

Line 181 in 0d250ae

if extract_archive and (is_zipfile(file_path) or tarfile.is_tarfile(file_path)):

and

cached_path/cached_path/_cached_path.py

Line 201 in 0d250ae

and (is_zipfile(file_path) or tarfile.is_tarfile(file_path))
Add RPM extraction code after the block at

cached_path/cached_path/_cached_path.py

Line 245 in 0d250ae

if is_zipfile(file_path):
It might also be sensible to include a test verifying the extraction code into https://github.com/allenai/cached_path/blob/main/tests/cached_path_test.py.

I'm currently working around this by explicitly checking for RPM files when using cached_path and extracting the cached RPMs. It would be much cleaner to rely on cached_path for this however :)

I could write and PR this code if you're interested. Let me know if that's the case.

Hey @LeStahL I'd be happy to review a PR for this

Support extracting files from RPM archives.