Hard coded secret in code
skrskr opened this issue · comments
you need to add api_key and base url to .env file and create config file for example tap.php.
if base url and api key changed from testing to production it's easy to change it on .env file only not every where on code.
Thank you Mohamed 👍
…On Tue, Feb 15, 2022 at 10:17 PM Mohamed Sakr ***@***.***> wrote:
https://github.com/alijumaan/laravel-ecommerce/blob/f098bb546989195c8918ec801ed0eee85e7284dc/app/Services/TapService.php#L23
you need to add api_key and base url to .env file and create config file
for example tap.php.
if base url and api key changed from testing to production it's easy to
change it on .env file only not every where on code.
—
Reply to this email directly, view it on GitHub
<#25>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARS5CJDBKYJEE57IAZA3RR3U3KRCXANCNFSM5OPO5QCQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>