algorand / go-algorand-sdk

Algorand Golang SDK

Home Page:https://pkg.go.dev/github.com/algorand/go-algorand-sdk/v2

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add golangci-lint to CI process

algochoi opened this issue · comments

Problem

Supercedes #168

We want to enforce a linter in the Go SDK repo, just like our other repos.

Solution

  • Add reviewdog/action-golangci-lint@v2 Github Actions workflow
    • We can enforce it after a particular commit hash, and slowly fix existing lint errors over time or just fix those errors at once.
  • Add a .golangci.yml file (use Conduit configurations as an example)
    • We should exclude generated files from linters as we cannot control those
  • Use golangci-lint in the make lint step. We can also add a go vet step.

Considerations: