algorand / go-algorand-sdk

Algorand Golang SDK

Home Page:https://pkg.go.dev/github.com/algorand/go-algorand-sdk/v2

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade golang version to 1.16

jasonpaulos opened this issue · comments

Problem

This SDK is currently on golang v1.13, and soon go-algorand will update to v1.16.10 (tracked by algorand/go-algorand#2825).

Since this SDK imports parts of go-algorand, it most likely needs to be updated to version 1.16 as well.

Solution

Upgrade to 1.16

Bumping back, as this doesn't make sense until go-algorand is closer to released as 1.16.

We should probably do this on go-algorand first as well, otherwise the SDK won't be able to update to a version of go-algorand that uses 1.16: algorand/go-algorand#3355

Wouldn't it be better to update the SDK first since it depends on go-algorand? All the code we depend on is forwards compatible. If we wait for go-algorand first, then we risk being broken by unsupported features if the SDK is still on an older version of Go.

Closed by #301

Wouldn't it be better to update the SDK first since it depends on go-algorand? All the code we depend on is forwards compatible. If we wait for go-algorand first, then we risk being broken by unsupported features if the SDK is still on an older version of Go.

That's a good idea, though in practice we just updated them at the exact same time