Giters

algolia / search-insights.js

Library for reporting click, conversion and view metrics using the Algolia Insights API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Group typecheking in a function to lighten _sendEvent function

tkrugg opened this issue · comments

commented

follows up on this comment: https://github.com/algolia/search-insights.js/pull/34/files#r240540872

Problems to address:

  • sendEvent function is a bit dense right now:
  • do typecheking earlier. Typechecking is more useful when it happens at the start of a public method (click, conversion and view methods) rather then later.
commented

closing the issue because the schema validations were removed #325