algolia / instantsearch

⚡️ Libraries for building performant and instant search experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.

Home Page:https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`indexId` missing in `AutocompleteRenderState` type while being listed in the docs

axrez opened this issue · comments

🐛 Current behavior

The documentation for autocomplete shows the indices containing a property named indexId, but this isn't reflected in the AutocompleteRenderState type here. This means that we can't index on the indexId without writing some smelly typescript.

🔍 Steps to reproduce

Providing steps to repro this type mismatch seems a bit excessive. However, I'm happy to do it if the above description isn't sufficient.

Live reproduction

See comment above

💭 Expected behavior

I would expect the AutocompleteRenderState type in this file to contain the indexId like described in the docs.

Package version

instantsearch.js 4.64.3

Operating system

macOS 14.2.1

Browser

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

That's correct, thanks. I've just made a PR (#6050) to address this.

Wow that was fast. Thanks for moving so quickly on this 🙌