Giters

algolia / github-awesome-autocomplete

:octocat: Add instant search capabilities to GitHub's search bar

Home Page:https://github.algolia.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Provide a option change `this repository` to `all repository`

eromoe opened this issue · comments

commented

Hello

I usually not tend to search keyword in this repository while I am in a repo.

For example, I am in github-awesome-autocomplete report this feature request, and then I want to search github notification enhance , I have to click github home icon to home page to do the search.

commented

Hey @eromoe ,

Thanks for reaching out.

Is it this part you want to change?
image

This feature mimics the default GitHub behaviour.
If you press the return button multiple times however it will remove the current repository scope.

Let me know if that is not what you meant.

commented

@rayrutjes

I mean provide a config option change

image

to

image

Maybe a dropdown list :

  1. search github
  2. search this repository

and user can config the default order .

commented

I think I see what you mean.
You are searching for a repo, but don't find a suitable answer in the autocompleted results then you want to submit the request globally and not to the repo only.

I think that makes sense and best would probably be to add a suggestion a second choice of the dropdown.

I don't think we will add "options" for now because it requires more setup but definitely something we could do in the future.

commented

@eromoe what do you think of #70 ? Was that what you had in mind?

commented

A little different ,

Provide Config Option Would be good

Right click github-awesome-autocomplete icon

image

the second grey out menu item is option.

I would feel better to go into option and choose the behavious of the search box in a repository.

Default Search Box Behavious

  1. Default behavious is like you PR

    image

    • Press "Enter" to search xxx in this repo
    • there is a this repository in front of search box

  2. But one can change default behavious to

    • Press "Enter" to search xxx in all repo
    • no this repository in front of search box (default search all repo)

I want this because I barely use "search xxx in this repo" . I usually prefer clone a repo , search keyword and view detail in a IDE.

commented

Hey @eromoe ,

I think that this feature alone does not justify the additional dedicated options page.

Also, our initial idea here was that the default "enter" mimics the GitHub behaviour.
If you want to search globally you could also always start by removing the "This repository" label.

I'll leave this open here to see if more users are interested.

commented

Solved by #76 .