algolia / github-awesome-autocomplete

:octocat: Add instant search capabilities to GitHub's search bar

Home Page:https://github.algolia.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Does not work after having filtered on a language

rayrutjes opened this issue · comments

When on a repository search page, if we filter by language, the search is reloaded asynchronously which breaks the bindings.

Maybe we could delegate the binding to a higher level in the dom tree?

image

Hmmm, good catch :/

But what should we do since we don't have the data to provide a faceted search based on the language :/ Breaking the binding is now good, but I'm wondering if we want to show the dropdown menu to the user once he selected a language :/

You are right. I think breaking the binding makes sense actually as we do not have the language as a facet. Feel free to close.