Giters

alexweininger / recent-pdf

a chrome extension for easy access to recently viewed PDF files

Home Page:https://chrome.google.com/webstore/detail/recent-pdf/ihjgdammecebcjinfmllgniaeneabkdk

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pin files

alexweininger opened this issue · comments

commented

I would like to add the ability to pin / save pdf files. This could be done and viewed in several different ways.

  1. User pins files, and they appear at the top of the corresponding (local/online) list until they are unpinned.
  2. User pins files, and in addition to appearing in their local/online list, they appear in a new list located in a new tab/section named 'Saved' or 'Pinned'.
commented

Hi Alex! Cool project-- I could see it being really useful for me at work! I am interested in working on this issue. Two questions come to mind off the bat:

  1. Have you thought more about which UI might work best?
  2. Do you have a preferred approach for persisting saved pdfs? I will look into the options here as well.
commented

Hey Hilary! Thanks! I'm glad it might be useful to you.

To answer your questions:

  1. Considering both options, I think adding another tab that holds your "Saved" files is the way to go. What do you think?
  2. Whatever seems simpler to you, I'd go for that. When they save a file, just add it to a list and display it on the "Saved" tab. As for actually saving a file, this is related to #9 where @ynx0 is working on a context menu button. In this menu we would add a "Save file" option.

Since this is relying on a few things at once, maybe start with the logic/code first, and the UI later? Let me know what you think.

Thanks!
Alex

commented

@hwinn4 If you could take a look at #31 for me it'd be a great help! I was having some glitches on the version and want to make sure it was just me and not others as well. More details are available on the PR.

commented

@alexweininger Sounds good! I will start looking at the logic for saving and can integrate with the context menu later. I can do something really simple in the meantime, just so there is a way to save for dev purposes.

I can also take a look at #31 and get back to you 👍

commented

@hwinn4 Want to try to work on this again? :)

It's hacktoberfest again!