Settings page

Question

Settings page

alexweininger opened this issue 6 years ago · comments

Alex Weininger commented 6 years ago

Instead of a settings page, would it be possible to have settings within the popup?

Or should we continue with the settings being a whole page?

Let me know what you think.

Crokky · Answer 1 · Tue Oct 16 2018 18:21:10 GMT+0800 (China Standard Time)

hello, could I try to work on it?

Alex Weininger · Answer 2 · Tue Oct 16 2018 18:22:08 GMT+0800 (China Standard Time)

Totally! What direction are you thinking of going?

Crokky · Answer 3 · Tue Oct 16 2018 18:23:32 GMT+0800 (China Standard Time)

I'd like to try to make a settings within the popup.

Alex Weininger · Answer 4 · Tue Oct 16 2018 18:24:26 GMT+0800 (China Standard Time)

Sounds good! There is already some logic there for the tabs, I'm sure you could use that.

Crokky · Answer 5 · Thu Oct 18 2018 00:49:36 GMT+0800 (China Standard Time)

Hello, Alex, I have a time to start working, what do I need to start from?

Alex Weininger · Answer 6 · Thu Oct 18 2018 06:20:50 GMT+0800 (China Standard Time)

Probably start with getting familiar with how the tabs work right now. The logic is at the bottom of script.js

Crokky · Answer 7 · Wed Oct 24 2018 02:48:42 GMT+0800 (China Standard Time)

Hi, Alex, I have a version of popup, how can I show u?

Alex Weininger · Answer 8 · Wed Oct 24 2018 04:03:35 GMT+0800 (China Standard Time)

Awesome! Open up a pr!

Crokky · Answer 9 · Wed Oct 24 2018 04:09:10 GMT+0800 (China Standard Time)

Sorry it is my first projct:) can me tell me how to open up or load :)) thanks Dňa ut 23. 10. 2018 o 22:03 Alex Weininger <notifications@github.com> napísala(a):

…

Awesome! Open up a pr! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ap-_zULMbK4zw0jKkLg7oq_dqmpV8kZWks5un3YXgaJpZM4XdqEx> .

Alex Weininger · Answer 10 · Wed Oct 24 2018 04:22:22 GMT+0800 (China Standard Time)

I'd be happy to help tomorrow, I'm busy the rest of today. Thanks for your contribution! Talk to you tmr

Alex Weininger · Answer 11 · Sat Oct 27 2018 15:12:58 GMT+0800 (China Standard Time)

@Crokky sorry I've been super busy, I'll try to take a look at it this weekend and help you

Crokky · Answer 12 · Tue Oct 30 2018 17:38:03 GMT+0800 (China Standard Time)

Hello, I added the fork, could you check it ?

Crokky · Answer 13 · Wed Nov 07 2018 19:21:35 GMT+0800 (China Standard Time)

Hello, Alex, I have made pull request, could you check it? And I would like did you make code coverage of this project?

Alex Weininger · Answer 14 · Wed Apr 24 2019 04:15:34 GMT+0800 (China Standard Time)

added in v2