2.7.1 still has rotation offset bug

Question

2.7.1 still has rotation offset bug

ParticleCore opened this issue 3 years ago · comments

I have noticed that the release version does not match the current branch version in your master. As a result, the 2.7.1 still has a bug with rotation that causes it to rotate about an incorrect center point, but this is already corrected in the master branch in the GestureController file.

The commit with the fix was pushed 2 days after 2.7.1 was released so it missed that one:

f2ed7a6#diff-9b17b755bea484fcfcaba9988fd0cbacc41e74723bdfcef36bbaab86ce0d218e

Alex Vasilkov · Answer 1 · Mon Apr 19 2021 18:56:04 GMT+0800 (China Standard Time)

But why do you think it should be part of 2.7.1? Full list of included changes can be found here: https://github.com/alexvasilkov/GestureViews/releases/tag/v2.7.1

Can you describe your issue? Are you sure it is fixed in the latest code from the repository?

Particle · Answer 2 · Tue Apr 20 2021 01:03:41 GMT+0800 (China Standard Time)

Rotation bug in 2.1.7

Rotation bug fixed in latest repository version

I only reverted the commit above for the file GestureController and it was sufficient to cause the problem that exists in 2.1.7

Alex Vasilkov · Answer 3 · Tue Apr 20 2021 01:08:34 GMT+0800 (China Standard Time)

Yeah, I see, do you need the fix to be released asap?

Particle · Answer 4 · Tue Apr 20 2021 01:38:25 GMT+0800 (China Standard Time)

No need to hurry, fortunately this does not affect its usability, it is merely a UI inconvenience at this point for me.

Particle · Answer 5 · Fri May 21 2021 00:55:12 GMT+0800 (China Standard Time)

@alexvasilkov out of curiosity, is there any rough estimate on when the version with a fix for this is going to be released?

Alex Vasilkov · Answer 6 · Wed May 26 2021 18:48:11 GMT+0800 (China Standard Time)

Version 2.8.0 is released now.

But I checked out source code and sample app for v2.7.0 and v2.7.1 and can't reproduce the issue from the gifs above. Are you sure you didn't do any extra modifications that could cause this issue? There were no major changes to GestureController in v2.7.1 or earlier (at least in the past few years), so this issue must have been there for quite a while then.