How to differentiate output based on auth status?
panta opened this issue · comments
Commit 739c4a0 removed WithCustomAuth and WithBasicAuth.
What's the recommended way to obtain the same behaviour now?
Yes, but it's still useful to be able to return a more limited result to non-authenticated clients, instead of returning a 401 or 403. I can implement a middleware calling two different health handlers based on auth status, but in that case I'd have two separate but similar/identical copies of health checkers running in background, no?
Ah, I understand. Yes, this functionality was removed. As a replacement, I planned to add a more generic function to disable details on a request basis. This way you can decide in which situations you would like to disable details yourself. To do this, you would need to add a marker to the request context by calling a health.DisableResponseDetails(request.Context()) function whenever you want to return the reduced response. This could be called by your middleware. Would this be sufficient for you? This is just a rough sketch, I'm open for other ideas.
The marker/option would be nice. I was also thinking of separating and exposing the checks machinery from the handler(s), thus also allowing to further customize the output and the strategy of handling. I've seen this approach adopted in hellofresh/health-go for example. What would you think?
I've provided an implementation in panta/feature/standalone-checkers (just a matter of making the checker -> Checker interface public, add a NewChecker() function, and some other very minor adjustments).
If you feel this might be useful to others I'll send a PR.
Thanks. I looks interesting, indeed! Happy to get a PR for this. I'll look into it tonight.
Merged with #5
In case you're still interested in a solution: The new version 0.5.0 has a BasicAuth middleware that should do what you want.
Actually I need to use it with a different auth mechanism, but the stand-alone checkers are perfect for that!
Thanks!