Does not reconnect after the socket is closed twice

Question

Does not reconnect after the socket is closed twice

nevercast opened this issue 11 years ago · comments

I expected EverSocket to reconnect me regardless of the amount of times I was disconnected, but it seems that when destroy is called after close the first time, it removes the close listener in the _destroy handler.

Because the handler for close is removed, any future disconnections are ignored, and are not reconnected.

Alex Wolfe · Answer 1 · Mon Oct 07 2013 11:23:41 GMT+0800 (China Standard Time)

Thanks for reporting this issue. I'd like to get this fixed. Do you have a small sample of some code I could use to reproduce it? Even pseudocode would help.

Josh Lloyd · Answer 2 · Mon Oct 07 2013 11:56:32 GMT+0800 (China Standard Time)

https://github.com/nevercast/eversocket-bug-example

Here you go, Alex.

Josh Lloyd · Answer 3 · Mon Oct 07 2013 12:04:15 GMT+0800 (China Standard Time)

It seems that it doesn't reconnect if the connection is error'd out.
Is this intended operation?

Alex Wolfe · Answer 4 · Mon Oct 07 2013 12:24:32 GMT+0800 (China Standard Time)

Thanks for the example, Josh.

There's currently nothing in EverSocket to reconnect on error, though it's just an oversight. Let me see if I can come up with a way to gracefully reconnect on error.

Josh Lloyd · Answer 5 · Mon Oct 07 2013 12:53:02 GMT+0800 (China Standard Time)

Thanks Alex :)

Alex Wolfe · Answer 6 · Tue Oct 08 2013 03:30:50 GMT+0800 (China Standard Time)

Let me know if that doesn't fix the problem for you, Josh.