Uncaught ReferenceError: path is not defined

Question

Uncaught ReferenceError: path is not defined

JacobEvelyn opened this issue 9 years ago · comments

Jacob Evelyn commented 9 years ago

git-blame doesn't seem to be working for me any more. I get this error on any file I try:

Atom Version: 0.199.0
System: Mac OS X 10.9.5
Thrown From: git-blame package, v0.4.3

Stack Trace

Uncaught ReferenceError: path is not defined

At /Users/jacobevelyn/.atom/packages/git-blame/lib/git-blame.js:27

ReferenceError: path is not defined
    at atom-workspace.toggleBlame (/Users/jacobevelyn/.atom/packages/git-blame/lib/git-blame.js:27:60)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:238:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:519:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:354:22)
    at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:178:20)

Commands

  2x -0:09.5.0 core:close (div.release-notes.padded.pane-item.native-key-bindings)
     -0:00.4.0 git-blame:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "autocomplete"
    ],
    "themes": [
      "atom-dark-ui",
      "monokai"
    ],
    "audioBeep": false
  },
  "git-blame": {}
}

Installed Packages

# User
autoclose-html, v0.16.0
git-blame, v0.4.3
language-haml, v0.20.0
monokai, v0.14.0
pretty-json, v0.3.3
webbox-color, v0.5.6

# Dev
No dev packages

Jonathan Bender commented 9 years ago

👍

Peter Willis commented 9 years ago

👍

Patrick Armitage commented 9 years ago

👍

Alexander Shahorsky commented 9 years ago

👍

Andra Veraart commented 9 years ago

👍

Zoltan Erdos commented 9 years ago

👍

Izaak Schroeder commented 9 years ago

👍

Nathan Meyer commented 9 years ago

👍

Toshimaru commented 9 years ago

👍

Robert Stettner commented 9 years ago

👍

Matt Fikowski commented 9 years ago

👍

Niels Buus commented 9 years ago

👍

Ariel Deitcher commented 9 years ago

👍

Travis Hooper commented 9 years ago

👍

Damon Allison commented 9 years ago

👍

eburi commented 9 years ago

👍

moekhalil commented 9 years ago

👍

Jeff Sandberg commented 9 years ago

👍

Rafael Iga commented 9 years ago

👍

Tiago Silva commented 9 years ago

👍

Hendrich Attila · Answer 1 · Mon May 18 2015 22:43:08 GMT+0800 (China Standard Time)

👍

(On Linux)

Kurt Mueller · Answer 2 · Thu May 21 2015 05:00:43 GMT+0800 (China Standard Time)

Just got this 👍

Alex Wait · Answer 3 · Fri May 22 2015 01:22:15 GMT+0800 (China Standard Time)

👍 git-blame has been broken for me for weeks :(

Peace · Answer 4 · Fri May 22 2015 02:12:31 GMT+0800 (China Standard Time)

Also seeing the error on Atom for Windows

Adrian Lee · Answer 5 · Fri May 22 2015 03:01:16 GMT+0800 (China Standard Time)

I just published git-blame-plus with the fix. It's currently just a fork of git-blame. This is a temporary measure and I'll be happy to unpublish that package when bugs are fixed.

Ariel Deitcher · Answer 6 · Fri May 22 2015 03:16:09 GMT+0800 (China Standard Time)

still does not open

On Thu, May 21, 2015 at 12:01 PM Adrian Lee notifications@github.com
wrote:

I just published git-blame-plus https://atom.io/packages/git-blame-plus
with the fix. It's currently just a fork of git-blame. This is a temporary
measure and I'll be happy to unpublish that package when bugs are fixed.

—
Reply to this email directly or view it on GitHub
#90 (comment).

Adrian Lee · Answer 7 · Fri May 22 2015 03:20:49 GMT+0800 (China Standard Time)

There is another bug that is preventing the gutter from showing up. That issue is tracked in #89. Looking into it.

Adrian Lee · Answer 8 · Mon May 25 2015 07:55:19 GMT+0800 (China Standard Time)

@adeitcher, with Atom v0.201.0 and git-blame-plus v0.4.6, I'm able to toggle the pane. Any chance you can test it out?

Jeremy Attali · Answer 9 · Tue May 26 2015 03:51:51 GMT+0800 (China Standard Time)

👍 Running the issue as well on OS X Yosemite 10.10.3.

Ricardo Siqueira de Oliveira Leite · Answer 10 · Tue May 26 2015 04:28:41 GMT+0800 (China Standard Time)

👍
Linux (Elementary OS - Ubuntu 14.04 based)
Atom: 0.201.0
Git Blame version: 0.4.3

Peace · Answer 11 · Tue May 26 2015 11:43:14 GMT+0800 (China Standard Time)

v0.4.6 is not opening the gutter on Atom v0.201.0 / Windows 7.

The dev console reports a not-so-useful error when attempting to activate git-blame:

Unhandled promise rejection.
Error: Minified exception occurred; use the non-minified dev environment for the full error message and additional helpful warnings.

Adrian Lee · Answer 12 · Tue May 26 2015 14:24:13 GMT+0800 (China Standard Time)

@peacechen, I think that issue has to do with #89.

Since reactionary-atom-fork isn't maintained by the core team anymore, i'm thinking maybe it's time to move git-blame out of react completely.

Alex Corre · Answer 13 · Sat May 30 2015 05:02:38 GMT+0800 (China Standard Time)

hi @adrianlee44 thanks for the PR i'll pull that in and release an update. i also plan to move off of react as its causing lots of people issues. anyone interested in helping out please reach out!

Alex Corre · Answer 14 · Sat May 30 2015 05:03:49 GMT+0800 (China Standard Time)

@adrianlee44 i appreciate you're getting the fixes out there, but i'd prefer if we can keep from releasing forks. Apologies for something not getting these fixes out sooner! looking at your PR now.

Alex Corre · Answer 15 · Sat May 30 2015 05:08:08 GMT+0800 (China Standard Time)

Merged in #91 and released v0.4.4

Adrian Lee · Answer 16 · Sat May 30 2015 05:44:51 GMT+0800 (China Standard Time)

@alexcorre, thanks for merging the PR! I released the fork as a quick fix and have no intension of maintaining that or continue updating it if there is active development on this repo.