Table borders are not present in the ePub
bunglegrind opened this issue · comments
Similar to #50, borders are not present in the tables (and I suppose in every other place).
Save the following page:
https://dev.mysql.com/doc/refman/8.0/en/innodb-locking.html
with the custom CSS rules:
header,
#docs-sidebar-toc,
#docs-version-nav,
#docs-breadcrumbs,
#docs-in-page-nav-container,
footer
{
display: none!important;
}
.has-toc {
margin-left: 0!important;
border-left: none!important;
}
and check the borders of the first table.
I'm using Firefox on Windows, I haven't tested on Chrome.
The reason is the "border" property: in Firefox it's an empty string and when you grab its content in
save-as-ebook/web-extension/extractHtml.js
Line 329 in 12a4cbb
you get nothing.
I've locally fixed the issue by changing the content of the supportedCss array in
const supportedCss = [
'background-color',
'border-top-width',
'border-top-style',
'border-top-color',
'border-bottom-width',
'border-bottom-style',
'border-bottom-color',
'border-left-width',
'border-left-style',
'border-left-color',
'border-right-width',
'border-right-style',
'border-right-color',
'border-collapse',
'color',
'font',
'line-height',
'list-style',
'padding',
'text-align',
'display'
];
well, that's the same for padding
...and font