Giters

alex-page / jamzone.today

Worldwide collaboration made easy.

Home Page:https://jamzone.today

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Corner cases not correctly handled.

Bismay5467 opened this issue · comments

commented

Hi there @alex-page 👋! I was looking through this project. I found the idea appealing and was studying the codebase. During the study I came across some issues :

  • getTzOffset() under the index file in the utils directory will return a NaN value if the offset is in the format HH : MM becoz the NumberConstructor will fail to work. This is not the expected outcome from this function.
  • All the data in the zones router is obtained from the url search query. As all the values will be exposed to the user, if the user try to tinker with the values on the search query this may lead to the crashing of the router page or some errors. Hence I feel all the values obtained from the search query must be checked before working with those values. If any one of the required values is not right we may simply display an error page.

I have a thorough understanding of your codebase. If the issues mentioned above are assigned to me I can fix them as I have all the skillsets required to solve those issues. However I am not much into frontend UI designing but if that is needed I can develop a great looking error page (obviously responsive) after some research and under the right guidance.

commented

Hey @Bismay5467 if you want to start with working on the issue with certain timezones getting cropped incorrectly that would be awesome.

commented

I am going to do some changes to move the data out of the URL params. So don't feel like that is something you have to work on right now.

commented

@alex-page yeah I had noticed the issue in the zone route page. It is most likely the CSS properties are not correctly used which is causing that issue. As I have mentioned I am not much into CSS, hence I may take some time to make that work. If that is fine with you I can work on it.

Regarding the issues I have mentioned, it's great if can remove the data from the URL and make it work by managing the state for example.

I'd also want to raise your attention to the first issue I highlighted.

Cheers!

commented

Yep. If you want to work on:

getTzOffset() under the index file in the utils directory will return a NaN value if the offset is in the format HH : MM becoz the NumberConstructor will fail to work. This is not the expected outcome from this function.

Please do!