Log output is not colorized

Question

Log output is not colorized

barrywoolgar opened this issue 6 years ago · comments

Hello, the prettifier is not colorizing ActiveRecord log output because false is being passed into the Prettifier.prettify_sql call in AbstractAdapterLogPrettifier.

I've tried this with passing true and it doesn't seem to break my Rails log, so I'm not sure if this is intentional or not.

Thanks

Aleksey Leshchuk · Answer 1 · Tue May 29 2018 23:50:55 GMT+0800 (China Standard Time)

You are right, rails actually log with color, so it's may not be a problem to log with a color.

Barry Woolgar · Answer 2 · Wed May 30 2018 16:39:09 GMT+0800 (China Standard Time)

Hi @alekseyl I don't think this issue is resolved yet, please can we leave it open until there's an option to set the colorize option to true? I'll do a PR now to add an extra config option, unless you'd like to do it a different way? Thanks!

Aleksey Leshchuk · Answer 3 · Wed May 30 2018 16:50:55 GMT+0800 (China Standard Time)

0.1.18 doesn't suit your needs?

Barry Woolgar · Answer 4 · Wed May 30 2018 16:53:39 GMT+0800 (China Standard Time)

Hi, the latest version I see here on master is 0.1.17

Aleksey Leshchuk · Answer 5 · Wed May 30 2018 17:19:49 GMT+0800 (China Standard Time)

sorry, about it, must be got distracted and didn't make a push and build for a 0.1.18 version

Barry Woolgar · Answer 6 · Wed May 30 2018 17:57:28 GMT+0800 (China Standard Time)

No worries, thanks for updating this, works great!