aleksei0807 / react-images-uploader

React.js component for uploading images to the server

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Impressing and confusing

heraldb opened this issue · comments

Hi,

First of all, thanks for the nice work. It is easy to set up an environment to load up images, especially because you took care of the server side as well.

However, I feel a bit confused about a few things, maybe because I don't understand the idea of this.
In the first place, the "preview" suggests a view before something happens, but to me it seems a postview, because it shows images after they are uploaded, not before.

In the second place, there is a delete feature (cross in right upper corner of pre/postview images). But I don't understand the use of it, since the image is already uploaded, you can not prevent it from being uploaded and it neither deletes the uploaded file. So what is the idea it should affect?

What I would expect is that the preview shows images before uploading them and the delete feature would prevent them from being uploaded. So I am wondering if I am doing something wrong.

+1 I really like the simplicity of this component! Thanks!

I am running into roadbumps that relate to this as well. I am trying to upload images with a form to go along with it. It seems that it will always upload automatically when selected, and not when let's say a submit button is pressed? Interested in seeing how the delete button works as well, or if there are server endpoints that can be tied to it as well.

just use deleteImage: function(key: number, url: string) callback and remove the image from your server manually