aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.

Home Page:https://aleksandr-m.github.io/gitflow-maven-plugin/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`feature-finish` only resets artifact version when invoked from the branch to be finished

kzander91 opened this issue · comments

Steps:

  1. Checkout develop, current artifact version is 1.0.0-SNAPSHOT.
  2. mvn gitflow:feature-start
  3. Enter feature name my-feature.
  4. Plugin creates branch feature/my-feature, sets artifact version to 1.0.0-my-feature-SNAPSHOT.
  5. Checkout develop.
  6. Run mvn gitflow:feature-finish, select the my-feature branch and confirm.
  7. Plugin merges feature/my-feature into develop but does not set the artifact version back to 1.0.0-SNAPSHOT beforehand. If I switch to feature/my-feature first and then run gitflow:feature-finish, it does correctly set the version back before merging.

As a consequence, if I forget to checkout the feature branch to be merged before invoking feature-finish, I end up with the feature's artifact version on develop.

The desired behavior is that the plugin resets the artifact version regardless of the branch I have currently checked out.

Should be fixed by 4b40a6c

@aleksandr-m Nice, thanks 👍 . Do you have an ETA on when the next version might be available?

@kzander91 1.19.0 is released.