`feature-finish` only resets artifact version when invoked from the branch to be finished
kzander91 opened this issue · comments
Kai Zander commented
Steps:
- Checkout
develop
, current artifact version is1.0.0-SNAPSHOT
. mvn gitflow:feature-start
- Enter feature name
my-feature
. - Plugin creates branch
feature/my-feature
, sets artifact version to1.0.0-my-feature-SNAPSHOT
. - Checkout
develop
. - Run
mvn gitflow:feature-finish
, select themy-feature
branch and confirm. - Plugin merges
feature/my-feature
intodevelop
but does not set the artifact version back to1.0.0-SNAPSHOT
beforehand. If I switch tofeature/my-feature
first and then rungitflow:feature-finish
, it does correctly set the version back before merging.
As a consequence, if I forget to checkout the feature branch to be merged before invoking feature-finish
, I end up with the feature's artifact version on develop
.
The desired behavior is that the plugin resets the artifact version regardless of the branch I have currently checked out.
Aleksandr Mashchenko commented
Should be fixed by 4b40a6c
Kai Zander commented
@aleksandr-m Nice, thanks 👍 . Do you have an ETA on when the next version might be available?
Aleksandr Mashchenko commented
@kzander91 1.19.0
is released.