alefragnani / vscode-read-only-indicator

Read-Only Indicator Extension for Visual Studio Code

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Do not prompt on notification click

kAlvaro opened this issue · comments

When you click on the status bar indicator I'd expect to just switch the status rather than getting a prompt.

As follow-up, perhaps you can implement a new File Access: Switch File Access command (with possibly a better name) that can also be shown in command palette and (maybe) remove File Access: Change File Access.

Hi @kAlvaro ,

When the command was added, the API to work with status bar was limited, which requested the current UX. Now, there is some new APIs and maybe this could be possible.

Thanks for your suggestion

Hi @alefragnani , I've noticed this enhancement and I can see a potential implementation to this status bar functionality using existing functionality. I'm happy to open a pull request to address this issue if you wish.

Update: Although the solution is simple, it has come to my attention that the original functionality may want to be kept. Perhaps this is suitable for an extension configuration?

Hi @TomChapple ,

Feels free to send a PR. That was the idea when I added help wanted and hacktoberfest labels 👍 .

About the configuration, that's how I would like to see. It's better to have an extension configuration for this new behaviour.

Thank you