alecthomas / gometalinter

DEPRECATED: Use https://github.com/golangci/golangci-lint

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Install failing on go 1.6.1

jayvdb opened this issue · comments

gometalinter --install fails due to undefined: types.SizesFor on go 1.6, which is the latest for the method of installing go which coala is using on Travis CI xenial, but in general we do like to be testing with older versions to catch de-support situations.

It would be ideal if the installer deselected linters which are no longer supported on older versions, using best efforts only of course (and coala could submit issues/patches whenever this happens).

Also would be good if the README could indicate which is the minimum version that gometalinter is supporting.

+go get -u github.com/alecthomas/gometalinter
+gometalinter --install
Installing:
  deadcode
  dupl
  errcheck
  gochecknoglobals
  gochecknoinits
  goconst
  gocyclo
  goimports
  golint
  gosec
  gotype
  gotypex
  ineffassign
  interfacer
  lll
  maligned
  misspell
  nakedret
  safesql
  staticcheck
  structcheck
  unconvert
  unparam
  varcheck
# golang.org/x/tools/go/internal/packagesdriver
../../../gopath/src/github.com/alecthomas/gometalinter/_linters/src/golang.org/x/tools/go/internal/packagesdriver/sizes.go:94: undefined: types.SizesFor
WARNING: failed to install one or more linters: exit status 2 (installing individually)
# golang.org/x/tools/go/internal/packagesdriver
../../../gopath/src/github.com/alecthomas/gometalinter/_linters/src/golang.org/x/tools/go/internal/packagesdriver/sizes.go:94: undefined: types.SizesFor
WARNING: failed to install github.com/kisielk/errcheck: exit status 2
# golang.org/x/tools/go/internal/packagesdriver
../../../gopath/src/github.com/alecthomas/gometalinter/_linters/src/golang.org/x/tools/go/internal/packagesdriver/sizes.go:94: undefined: types.SizesFor
WARNING: failed to install honnef.co/go/tools/cmd/staticcheck: exit status 2
gometalinter: error: failed to install the following linters: github.com/kisielk/errcheck, honnef.co/go/tools/cmd/staticcheck

https://travis-ci.org/coala/coala-bears/jobs/486270655

We support 1.9-1.11 currently (authoritative versions are in the .travis.yml). 1.6 has not been supported for a long time.