install.sh is broken again

[Christian Höltje]

# Using proposed readme install.sh
$ curl -sSfL https://git.io/vp6lP | sh                                                                                                                                                      
alecthomas/gometalinter info checking GitHub for latest tag
alecthomas/gometalinter info found version: 2.0.8 for v2.0.8/darwin/amd64
alecthomas/gometalinter info installed ./bin/gometalinter
alecthomas/gometalinter info installed ./bin/gocyclo
alecthomas/gometalinter info installed ./bin/nakedret
alecthomas/gometalinter info installed ./bin/misspell
install: /tmp/gometalinter-2.0.8-darwin-amd64/govet: No such file or directory

# Using the goreleaser install.sh
$ curl -sSfL https://install.goreleaser.com/github.com/alecthomas/gometalinter.sh | sh
alecthomas/gometalinter info checking GitHub for latest tag
alecthomas/gometalinter info found version: 2.0.8 for v2.0.8/darwin/amd64
alecthomas/gometalinter info installed ./bin/gometalinter
alecthomas/gometalinter info installed ./bin/gocyclo
alecthomas/gometalinter info installed ./bin/nakedret
alecthomas/gometalinter info installed ./bin/misspell
install: /tmp/gometalinter-2.0.8-darwin-amd64/govet: No such file or directory

# v2.0.5 _used_ to work
$ curl -sSfL https://git.io/vp6lP | env TMPDIR=/tmp sh -s -- v2.0.5
alecthomas/gometalinter info checking GitHub for tag 'v2.0.5'
alecthomas/gometalinter info found version: 2.0.5 for v2.0.5/darwin/amd64
alecthomas/gometalinter info installed ./bin/gometalinter
alecthomas/gometalinter info installed ./bin/gocyclo
alecthomas/gometalinter info installed ./bin/nakedret
alecthomas/gometalinter info installed ./bin/misspell
alecthomas/gometalinter info installed ./bin/govet
install: /tmp/gometalinter-2.0.5-darwin-amd64/gosec: No such file or directory

With 2.0.8 it fails on govet with 2.0.5 it fails on gosec.

There are now no versions installable via the curl install.sh | sh

I feel like the install.sh should not know what linters are bundled together. It should just install whatever is in the ./bin/ directory.

[Alec Thomas]

install.sh is autogenerated by godownloader.

Also, I'm curious why you didn't just send a PR to fix the issue?

[Christian Höltje]

I’m not sure what is generating it or where the configuration for godownloader is.

I’ve only looked at the gorelease tool.

_{Sent with GitHawk}

[Christian Höltje]

Also, I'm curious why you didn't just send a PR to fix the issue?

It took longer than I thought, but I made just #530.