Giters

albertofem / rsync-lib

A simple PHP rsync wrapper library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Suggestions: Default values for options etc.

tomasnorre opened this issue · comments

commented

Hi,

Just learned about your library today, and consider using it.

I know libraries like this doesn't often change, but I find it hard to say if it's still active as there are some open issues from some time back, and the latest commit from July 2020.

But I have some suggestions I would like to know what you think about. Would then provide PRs if deciding to use the library.

  1. Having default value set for all boolean options like: setShowOutput()
    Having this would make the code smaller as I don't need to $rsync->setShowOutput(true) and why should I set it if I want it to false, then I would just not set it at all.

  2. There are some options missing, so I would like to add a PR with those. I would at first only add the options that I'm missing for my purpose, but more could be added later on.

  3. When is the next release planned? The current release (1.0.0) is from January 2018, and I would never require a dev-branch.

Hope you find some time to answer my questions.
Stay safe and take care.