akvo / akvo-lumen

Make sense of your data

Home Page:https://akvo.org/akvo-lumen

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Capitalized group names affects to derive-js transformation

tangrammer opened this issue · comments

Context

right now we capitalize group names by default in dataset view data-group
Screenshot 2021-01-12 at 10 52 44

Problem or idea

trying js transformation row["Non repeatable"]["Family name"]+" welcome" FAILS
but row["Non Repeatable"]["Family name"]+" welcome" SUCCEED

Screenshot 2021-01-12 at 10 53 51
Screenshot 2021-01-12 at 10 53 57

Solution or next step

How could we solve it?

@janagombitova @kardan should we adapt the backend to be case insensitive or just don't change letter case in frontend

PS: changing behaviour in client is just removing css class, backend changes should have more changes and tests and perhaps more unknown consequences (thinking in undo with existent datasets with 2 groups having different letter case)

@tangrammer I would say we show things are they are. So do not change letter case in the frontend. It is less work and the users see the data, titles, etc as it is put in.

finally we need to adapt "Metadata", "Main" and "Transformations" in backend side thus I don't think we want to show these values in lower case 🤔

Agree.