For Actions.replace() and Actions.reset() animated transition is happening

Question

For Actions.replace() and Actions.reset() animated transition is happening

kolarus opened this issue 4 years ago · comments

Bohdan Morozov commented 4 years ago

Version

react-native-router-flux v4.3.0
react-native v0.63.4
react: 16.13.1

Expected behaviour

When using Actions.replace() or Actions.reset() no animated transition should occur

Actual behaviour

Animated transition happens

Platform

IOS (Not tested on android yet)

Yohan Levy commented 3 years ago

Following

Oleksandr Dziuban · Answer 1 · Sun Mar 21 2021 01:57:12 GMT+0800 (China Standard Time)

Same issues after migration to 4.3.0 from 4.2.0, @aksonov Could you please check? Thanks!

Pavel Aksonov · Answer 2 · Wed Mar 24 2021 15:21:22 GMT+0800 (China Standard Time)

Please check latest master

Oleksandr Dziuban · Answer 3 · Fri Mar 26 2021 05:57:29 GMT+0800 (China Standard Time)

Please check latest master

Great, thanks, could you please deploy fix to latest npm package?

minuit.agency · Answer 4 · Fri Mar 26 2021 17:06:31 GMT+0800 (China Standard Time)

Hi @aksonov , thank you for the quick fix, I still have a transition animation when using Actions.reset() in 4.3.1, is there something I missed or a dependency that I should update?

Thanks

Pavel Aksonov · Answer 5 · Fri Mar 26 2021 17:43:05 GMT+0800 (China Standard Time)

Do you have animation in react-native/Example for Register replace screen?

…

26 марта 2021 г., в 12:06, minuitagency ***@***.***> написал(а): Hi @aksonov <https://github.com/aksonov> , thank you for the quick fix, I still have a transition animation when using Actions.reset() in 4.3.1, is there something I missed or a dependency that I should update? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3741 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCS4LUMKLM7CRZTZREKVTTFRFCTANCNFSM4ZPBTBHA>.

minuit.agency · Answer 6 · Fri Mar 26 2021 17:50:34 GMT+0800 (China Standard Time)

@aksonov just checked your code, the "type" prop was undefined that's why the animation loaded, I patched it with:

animationEnabled: (type === ActionConst.REPLACE || type === 'replace' || !type) ? false : true,

It works for me now

Pavel Aksonov · Answer 7 · Fri Mar 26 2021 17:52:39 GMT+0800 (China Standard Time)

Hm, this will broke 'push' type animations..

minuit.agency · Answer 8 · Fri Mar 26 2021 17:54:01 GMT+0800 (China Standard Time)

oh... what should I do? Why is "type" undefined ?

Pavel Aksonov · Answer 9 · Fri Mar 26 2021 19:26:19 GMT+0800 (China Standard Time)

Could you reproduce the issue with react-native/Example project?

…

26 марта 2021 г., в 12:54, minuitagency ***@***.***> написал(а): oh... what should I do? Why is "type" undefined ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3741 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCS4N5V3VG3Y7DTYQKHWLTFRKUVANCNFSM4ZPBTBHA>.

Oleksandr Dziuban · Answer 10 · Wed May 12 2021 18:09:23 GMT+0800 (China Standard Time)

@aksonov Hello, issue still exists, are you planning to resolve it and deploy new patch version? Thansk a lot

Bohdan Morozov · Answer 11 · Wed May 12 2021 18:12:07 GMT+0800 (China Standard Time)

Reopening, just checked, we still have animations

Erwan Baynaud · Answer 12 · Wed May 12 2021 18:18:01 GMT+0800 (China Standard Time)

Linked to https://github.com/react-navigation/stack/releases/tag/v2.0.1 ?

Paco Yang · Answer 13 · Wed Jun 02 2021 22:43:37 GMT+0800 (China Standard Time)

Same issue on 4.3.1

Yogendra · Answer 14 · Mon Feb 21 2022 14:39:29 GMT+0800 (China Standard Time)

The issue still persists, does someone have an idea how to resolve this?