Delete does not adhere to Eventsourced API

[Nicolas Vollmar]

Versions used

akka-persistence-jdbc version: 5.0.1

Expected Behavior

Scala doc of deleteMessages specifies

Permanently deletes all persistent messages with sequence numbers less than or equal toSequenceNr.

Actual Behavior

Events less than the specified toSequenceNr are deleted only - query still returns last event that should also have been deleted.

Reproducible Test Case

See DeleteTest in #550

[Nicolas Vollmar]

I did some investigation, and adding

.filter(!_.deleted)

to

akka-persistence-jdbc/core/src/main/scala/akka/persistence/jdbc/query/dao/ReadJournalQueries.scala

Lines 37 to 47 in 2f7ec79

 private def _messagesQuery( 
     persistenceId: Rep[String], 
     fromSequenceNr: Rep[Long], 
     toSequenceNr: Rep[Long], 
     max: ConstColumn[Long]) = 
   baseTableQuery() 
     .filter(_.persistenceId === persistenceId) 
     .filter(_.sequenceNumber >= fromSequenceNr) 
     .filter(_.sequenceNumber <= toSequenceNr) 
     .sortBy(_.sequenceNumber.asc) 
     .take(max) 

would fix the test