Do not delete items with null values from database!
4n70w4 opened this issue · comments
Krot Eval commented
Incorrect condition!
https://github.com/akaunting/setting/blob/master/src/Drivers/Database.php#L171
Test:
$insertData[$key] = null;
isset($insertData[$key]); // === false
Better use array_key_exists() instead isset()
Because null is cortrect value!
Denis Dulici commented
Feel free to contribute.
Krot Eval commented
@denisdulici why did you close? Issue not resolved! dislike for you!