akaunting / laravel-setting

Persistent settings package for Laravel

Home Page:https://akaunting.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Do not delete items with null values from database!

4n70w4 opened this issue · comments

Incorrect condition!

https://github.com/akaunting/setting/blob/master/src/Drivers/Database.php#L171

Test:

$insertData[$key] = null;
isset($insertData[$key]); // === false

Better use array_key_exists() instead isset()
Because null is cortrect value!

#43

Feel free to contribute.

@denisdulici why did you close? Issue not resolved! dislike for you!