NextRunAt - reports latest time not earliest

Question

NextRunAt - reports latest time not earliest

shunte88 opened this issue 7 years ago · comments

the logic for determining next run time for a set of jobs is reversed and thus reports the latest run at time for the set

	if nextRun.IsZero() {
		nextRun = jobs.NextRunAt
	//} else if (nextRun.UnixNano() - jobs.NextRunAt.UnixNano()) < 0 {
	} else if (nextRun.UnixNano() - jobs.NextRunAt.UnixNano()) > 0 {
		nextRun = jobs.NextRunAt // we want earliest not latest
	}

simple fix to reverse the test ( > 0)

Sam Cook · Answer 1 · Mon Oct 23 2017 10:53:41 GMT+0800 (China Standard Time)

Is it just the one line that needs to be changed?

Stuart Hunter · Answer 2 · Tue Oct 24 2017 22:00:37 GMT+0800 (China Standard Time)

yep just that one line

Sam Cook · Answer 3 · Wed Oct 25 2017 02:00:53 GMT+0800 (China Standard Time)

Sweet. I will trying forking it and fixing it