Broken unit test: “Should have guessed profile 'mum to one boy and one girl' was 'female', not 'male'”

Question

Broken unit test: “Should have guessed profile 'mum to one boy and one girl' was 'female', not 'male'”

lucaswerkmeister opened this issue 6 years ago · comments

$ python2.7 -m unittest discover -v
test_declared_gender (tests.test_declared_gender.TestDeclaredGender) ... FAIL

======================================================================
FAIL: test_declared_gender (tests.test_declared_gender.TestDeclaredGender)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/twitter-gender-distribution/tests/test_declared_gender.py", line 50, in test_declared_gender
    description, expected_gender, guess))
AssertionError: Should have guessed profile 'mum to one boy and one girl' was 'female', not 'male'

----------------------------------------------------------------------
Ran 1 test in 0.080s

FAILED (failures=1)

Lucas Werkmeister · Answer 1 · Thu Jun 28 2018 14:38:26 GMT+0800 (China Standard Time)

git bisect says that f272560 is the first bad commit. (Part of #10, so CC @raptortech-js.)

Jackie Scholl · Answer 2 · Fri Jun 29 2018 01:28:00 GMT+0800 (China Standard Time)

Yup, looks like I did that! You can definitely fix it by reverting part or all of f272560, though if you do that you will break, e.g., "guy who loves his mum." I'm not sure which formulation is more common, so I don't know if it makes more sense to change the test or change (back) the priority order

Regardless, I have no personal stake and I'm happy with whatever ends up happening :)

A. Jesse Jiryu Davis · Answer 3 · Fri Jun 29 2018 05:39:53 GMT+0800 (China Standard Time)

Let’s say, if there is more than one gender clue in the profile text, then guess using first name as if there were no gender clues.

…

On Thu, Jun 28, 2018 at 1:28 PM Jackie Scholl ***@***.***> wrote: Yup, looks like I did that! You can definitely fix it by reverting part or all of f272560 <f272560>, though if you do that you will break, e.g., "guy who loves his mum." I'm not sure which formulation is more common, so I don't know if it makes more sense to change the test or change (back) the priority order Regardless, I have no personal stake and I'm happy with whatever ends up happening :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFIhcIGitr4ObydlvR7yteYnpQzGWF_ks5uBRIhgaJpZM4U602L> .