(ace-code): Incorrect typings for 'ace-code/src/mode/swift_highlight_rules'
just-boris opened this issue · comments
Describe the bug
The typings for swift_highlight_rules do not match the actual behavior
// import according to the types
import { SwiftHighlightRules } from "ace-code/src/mode/swift_highlight_rules";
// actual import, works in runtime, but broken in typescript
import { HighlightRules } from "ace-code/src/mode/swift_highlight_rules";Ace Version / Browser / OS / Keyboard layout
1.32.3
Hey, @just-boris! Is this something you could submit a PR for?
I think there is a fundamental issue with your project, that such integrations are not tested properly. It is not something which an external contributor can fix.
For my tasks I already unblocked myself, see the linked pr, I could just remove the dependency on the problematic code.
In terms of the fundamental issue: Ace is a vanilla JavaScript project and we're adding type-checking capabilities to it incrementally to improve our testing posture.
In terms of this specific issue, despite your mitigation: does #5516 fix it?
Yes, that works. Thanks