Giters

ajaxorg / ace

Ace (Ajax.org Cloud9 Editor)

Home Page:https://ace.c9.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

gutter: "Read annotations row X" aria-label doesn't contain the type of annotation

avinashbot opened this issue · comments

commented

Describe the bug

In the gutter, when an annotation icon is present, the aria-label just states "Read annotations row X", but doesn't provide any information to assistive technology whether it's an info, warning, or error icon.

Expected Behavior

Ideally, the aria-label should be something like "Error, read annotations, row 1" or "Warning, read annotations, row 1", where the string starts with the icon type of the button being focused.

Current Behavior

When testing (with enableKeyboardAccessibility enabled), VoiceOver on Mac reads the icon as "Read annotations, row 1, button". No information about the icon itself is communicated to screen readers.

Reproduction Steps

  1. Open ace with a language that supports syntax checking (e.g. Javascript in the kitchen sink)
  2. Cause a syntax error or a warning.
  3. See that the .ace_gutter_annotation in the DOM has an aria-label without the icon type mentioned in it.

Possible Solution

No response

Additional Information/Context

Relevant lines: src/layer/gutter.js

Ace Version / Browser / OS / Keyboard layout

^1.32.6 / Any / Any / Qwerty

commented

Seems like this was resolved by #5524 back then, closing the issue