Broken link on http://airbnb.io/projects/ruby/

Question

Broken link on http://airbnb.io/projects/ruby/

nodanaonlyzuul opened this issue 7 years ago · comments

Stephen Tiberius Schor commented 7 years ago

Hullo.

Firstly, thanks for the hard work and sharing your style guides.
http://airbnb.io/projects/ruby/ link to the Google C++ style guide is broken (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml).

The C++ guide now lives here: https://google.github.io/styleguide/cppguide.html

I know http://airbnb.io/projects/ruby/ isn't governed by this repo but that page links to this repo under the "start a convo" button. I did a bit of digging to find the repo containing the source for airbnb.io but couldn't find it.

Let me know if there's a more appropriate repo for this ticket and again THANKS!

Adan Amarillas · Answer 1 · Tue May 15 2018 02:44:53 GMT+0800 (China Standard Time)

Hello,

I am looking to make my first open source contribution. Is this a good issue to take on?
If not, feel free to point me other issues that might be good for someone that's new to open source.
Thanks!

Jordan Harband · Answer 2 · Tue May 15 2018 02:48:25 GMT+0800 (China Standard Time)

@aamarill sure, that'd be great, thanks

Adan Amarillas · Answer 3 · Tue May 15 2018 03:37:08 GMT+0800 (China Standard Time)

@ljharb can you please let me know where the repo for https://airbnb.io/projects/ruby/ is? I couldn't find it, I also read the "CONTRIBUTING.md" and couldn't find anything on the repo. Thanks!

Jordan Harband · Answer 4 · Tue May 15 2018 04:38:16 GMT+0800 (China Standard Time)

ah, turns out this was already fixed in #105, but hasn't been updated in the private repo for airbnb.io.

I'll pursue this internally.

Stephen Tiberius Schor · Answer 5 · Fri May 18 2018 10:42:04 GMT+0800 (China Standard Time)

Hi @ljharb !

I'm going to close this ticket if the repo that governs that static site is private and trust you to open up a ticket in that repo. Thanks to you and @aamarill for looking into this ticket.