Issues with HMR

Question

Issues with HMR

toddw opened this issue 8 years ago · comments

When using react-with-styles and hot-module-replacement, the styles object passed in by props is not updating without a full page refresh.

Joe Lencioni · Answer 1 · Sat Dec 03 2016 07:51:16 GMT+0800 (China Standard Time)

Thanks for the report! I'd be happy to review a PR that fixes this.

Mike Fowler · Answer 2 · Fri Jan 06 2017 23:51:52 GMT+0800 (China Standard Time)

@toddw, I recently upgraded a personal project to use React Hot Loader 3 (upgrade example) and react-with-styles does seem to be working with HMR. Maybe give that a shot?

Sungho Cho · Answer 3 · Wed Sep 05 2018 08:13:55 GMT+0800 (China Standard Time)

I'm facing the same issue as @toddw. Styling directly with aphrodite, hot module replacement (HMR) works as expected, and updates the style, but with react-with-styles, HMR seems to be broken and styles prop is not getting updated, thus not updating style as expected. Does react-with-styles do anything special to handle HMR? Or is something out of react-with-styles broken?