Giters

airblade / vim-gitgutter

A Vim plugin which shows git diff markers in the sign column and stages/previews/undoes hunks and partial hunks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Neovim now prefers extmarks to signs

airblade opened this issue · comments

commented

There is no need to rush to use the extmark API instead of the :sign commands (I doubt they will ever be deprecated). The point of neovim/neovim#25724 was to make sure that neovim uses extmarks internally to display signs placed using the :sign commands.

If you're making a neovim only plugin sure, the extmark API may be preferred. But I wouldn't bother maintaining both a :sign and extmark implementation :)

commented

Thanks for the info, I appreciate it.

It seems clear that the :sign commands are regarded as legacy, so it wouldn't surprise me if sooner or later they were dropped. Even if they aren't, I'd prefer to use the recommended API.

As for maintaining both a :sign and extmark implementation, vim-gitgutter maintains compatibility with old / legacy APIs back to Vim 7.4 while using newer APIs if available. Backwards compatibility is tedious though :)

commented

On second thoughts I'll follow your advice and leave this for now.