aio-libs / aiodocker

Python Docker API client based on asyncio and aiohttp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing dependency makes current release unusable

knrdl opened this issue · comments

Version 0.22.0 introduced typing_extensions as dependency without listing it:

dda48e6#diff-e78bf2f78fa1e511301ed157715a6a283763a55fb90af54c22fc4c0495785e55R12

  • Expected behaviour: works
  • Actual behaviour: crashes after import

How to reproduce

pip install aiodocker

python -c 'import aiodocker'

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.12/site-packages/aiodocker/__init__.py", line 1, in <module>
    from .docker import Docker
  File "/usr/local/lib/python3.12/site-packages/aiodocker/docker.py", line 27, in <module>
    from aiodocker.types import JSONObject
  File "/usr/local/lib/python3.12/site-packages/aiodocker/types.py", line 12, in <module>
    from typing_extensions import TypeAlias
ModuleNotFoundError: No module named 'typing_extensions'

Your environment

docker image with tag 3.12.4

commented

this is a showstopper and imho should be treated as urgent - it means that aiodocker doesnt work out of the box in a clean environment

I've opened a PR to fix this: #877

Oops, thanks! I will check it out!

Making a hotfix release v0.22.2!