Remove `_register_lazy_block_unknown_fips_pseudo_regions`

Question

Remove `_register_lazy_block_unknown_fips_pseudo_regions`

crispinlogan opened this issue 3 years ago · comments

Describe the bug
Remove _register_lazy_block_unknown_fips_pseudo_regions from AioClientCreator in client.py. Why? _register_lazy_block_unknown_fips_pseudo_regions was intentionally removed from botocore (and AioClientCreator inherits from botocore's ClientCreator, where _register_lazy_block_unknown_fips_pseudo_regions was originally defined) as it was used for testing purposes only, and seems to have been added to aiobotocore inadvertently, so now that it has been removed from botocore, it should also be removed from aiobotocore, otherwise you will get a AttributeError: _register_lazy_block_unknown_fips_pseudo_regions attribute does not exist type error.

This comment on an issue in botocore also explains the issue and gives some more context.

Checklist

I have reproduced in environment where pip check passes without errors
I have provided pip freeze results
I have provided sample code or detailed way to reproduce
I have tried the same code in botocore to ensure this is an aiobotocore specific issue
I have tried similar code in aiohttp to ensure this is is an aiobotocore specific issue
I have checked the latest and older versions of aiobotocore/aiohttp/python to see if this is a regression / injection

pip freeze results

Environment:

Python Version: [e.g. 3.6]
OS name and version: [e.g. darwin stretch]

Additional context
Add any other context about the problem here.

MazzMa · Answer 1 · Wed Nov 17 2021 22:07:43 GMT+0800 (China Standard Time)

I have the same issue with the versions:

aiobotocore==1.4.2    
aiohttp==3.8.1        
aioitertools==0.8.0   
aiosignal==1.2.0      
async-timeout==4.0.1  
attrs==21.2.0         
boto3==1.20.4         
botocore==1.23.7      
pandas==1.3.3
`

ctippur · Answer 2 · Thu Nov 18 2021 00:16:02 GMT+0800 (China Standard Time)

Does this issue involve to_csv() as well?
Looks like the call is not writing to S3. I dont see any errors either.

Neil Jonkers · Answer 3 · Mon Nov 22 2021 17:45:26 GMT+0800 (China Standard Time)

No, to_csv() is not impacted by this issue.

Alexander Mohr · Answer 4 · Fri Nov 26 2021 07:29:18 GMT+0800 (China Standard Time)

this is not a bug, aiobotocore 1.4.2 is tied to botocore 1.17.106: https://github.com/aio-libs/aiobotocore/blob/1.4.2/setup.py#L10. This strong tie is due to how aiobotocore is implemented. If you'd like to use a newer botocore you need to swap to aiobotocore 2.x

Alexander Mohr · Answer 5 · Fri Nov 26 2021 07:29:32 GMT+0800 (China Standard Time)

please re-open if I'm missing something

Shogo Hayashi · Answer 6 · Sat Nov 27 2021 17:56:28 GMT+0800 (China Standard Time)

I couldn't reopen this issue(only repo owner or collaborator can reopen as far as I know), so I created the same issue newly.
#905

Swathi · Answer 7 · Mon Nov 29 2021 06:08:54 GMT+0800 (China Standard Time)

this is affecting to_csv() as well