FirstOrderVisitor.java in package aima.extra.logic.firstorder.parser missing implementation dependent classes

Question

FirstOrderVisitor.java in package aima.extra.logic.firstorder.parser missing implementation dependent classes

hriaz17 opened this issue 6 years ago · comments

As you can see, FirstOrderVisitor.java requires several missing classes to be implemented in aima-4e, hence it is throwing up errors when running unit tests as well. Should I copy over implementations from aima-3e to make it work @utsavoza @ctjoreilly @norvig?

Utsav Oza · Answer 1 · Sat Mar 24 2018 03:13:34 GMT+0800 (China Standard Time)

@harisriaz17 The FirstOrderParser and PropositionalLogicParser are generated from their respective ANTLR grammar files when you build the project, or extra gradle module. I suppose in Eclipse IDE, you need to manually 'refresh the gradle project' after the build inorder for these changes to get reflected in the IDE.

Haris Riaz · Answer 2 · Sat Mar 24 2018 03:20:38 GMT+0800 (China Standard Time)

Alright - thanks for your help! I got those files generated. Since you're here, can you please review this PR for me?
I wrote a couple of basic unit tests for the activation and derivative function used in neural networks (forward and back prop).
#368

Samagra Sharma · Answer 3 · Sun May 20 2018 15:53:19 GMT+0800 (China Standard Time)

This issue seems to have been resolved. Therefore I am closing this issue.