Giters

aigis-styleguide / aigis

CSS Styleguide Generator

Home Page:http://aigis-styleguide.github.io/aigis/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

font definitions in theme.css conflict with author definitions

myakura opened this issue · comments

commented

Hi.
I just found that theme.css defines font-family and font-size in body.

body {
  margin: 0;
  padding: 0;
  font-family: "Helvetica Neue",Helvetica,arial,nimbussansl,liberationsans,freesans,clean,sans-serif,"Segoe UI Emoji","Segoe UI Symbol";
  font-size: 1rem; }

I find this problematic; the stylesheets on which I'm currently working specify font styles in html but not inbody so those font styles overrides mine.

I know this theme.css is kinda "as a bonus" thing; yeah we can define our own styles. But I still feel those font-family and font-size in body a bit opinionated.
If you want to specify font styles for the template, you might wanna do on .aigis-** instead of body.

[class^="aigis-"] {
  font-family: "Helvetica Neue",Helvetica,arial,nimbussansl,liberationsans,freesans,clean,sans-serif,"Segoe UI Emoji","Segoe UI Symbol";
  font-size: 1rem; 
}
/* we may use `[class|=aigis]` but I feel it's too smart */

wdyt?