Giters

ahorn / android-rss

Lightweight Android library to parse RSS 2.0 feeds.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rfc822DateParser is not thread safe

xmaux72 opened this issue · comments

commented

Hi,

I'm using your library to read many rss feeds at a time.
I noted strange dates in my articles and searching the code I noticed that:

/**

  • @see RFC 822
    */
    private static final SimpleDateFormat RFC822 = new SimpleDateFormat(
    "EEE, dd MMM yyyy HH:mm:ss Z", java.util.Locale.ENGLISH);

SimpleDateFormat is NON thread-safe so you can't declare as static
https://stackoverflow.com/questions/6840803/why-is-javas-simpledateformat-not-thread-safe

Thanks for your great work.

commented

Hi @xmaux72. Thanks for the comment. I'd accept a pull request that fixes this issue. Is the other code thread-safe?

commented

Hi @xmaux72

For some time now, I wanted to update the README with some contributor information, and references to projects/products that are using android-rss. If you are willing to share any of this information, please feel free to provide the following, or a subset thereof:

  • Your name and/or organization you would like to be mentioned;
  • The project name, or product, that is using android-rss.

Many thanks again for your contributions!