Make RSSBase, RSSFeed and RSSItem Parcelable

Question

Make RSSBase, RSSFeed and RSSItem Parcelable

Maragues opened this issue 9 years ago · comments

Miguel Aragues commented 9 years ago

To avoid requests on orientation change, being able to Parcel this items would make things easier.

I can make the PR, but it's terrible to still work on a Eclipse project structure :(

ahorn commented 9 years ago

Cool!

ahorn · Answer 1 · Tue Jul 21 2015 00:32:27 GMT+0800 (China Standard Time)

[I]t's terrible to still work on a Eclipse project structure

What is being used these days?

Miguel Aragues · Answer 2 · Tue Jul 21 2015 16:17:27 GMT+0800 (China Standard Time)

http://developer.android.com/tools/studio/index.html

Also, Android now uses Gradle as its build system

ahorn · Answer 3 · Wed Jul 22 2015 00:45:20 GMT+0800 (China Standard Time)

Looks interesting. If you want to setup a build as described above, I'd accept a patch.

Miguel Aragues · Answer 4 · Wed Jul 22 2015 16:01:15 GMT+0800 (China Standard Time)

Hi ahorn, I'm afraid I've decided to not use your library, since it wasn't parsing correctly a RSS feed.

Still, if you open the project with Android Studio, it shouldl automatically transform it to the gradle structure. Good luck!

ahorn · Answer 5 · Wed Jul 22 2015 17:52:48 GMT+0800 (China Standard Time)

Okay. Out of curiosity, which feed? What library are you using instead?

Miguel Aragues · Answer 6 · Wed Jul 22 2015 18:07:08 GMT+0800 (China Standard Time)

Oh, actually I messed up and I am using your library, only I'm not trying to parcel items :-) I ditched another one (https://github.com/Pkmmte/PkRSS) that did have parsing problems.

If I have time I'll try to make the PR

ahorn · Answer 7 · Wed Jul 22 2015 18:12:31 GMT+0800 (China Standard Time)

As far as I know, PkRSS uses an XML pull parser. By contrast, android-rss uses SAX. According to @steveliles, SAX parsing on Android is an order of magnitude faster than other parsing techniques [1].

If you find android-rss helpful, great. And if want to fix any issues here or there (including the build), any patches are of course warmly welcome.

[1] https://github.com/steveliles/dsl4xml-perf

ahorn · Answer 8 · Fri Jul 31 2015 21:30:02 GMT+0800 (China Standard Time)

Hi, how is this going?

ahorn · Answer 9 · Sat Aug 08 2015 06:35:38 GMT+0800 (China Standard Time)

Hi there, I hope this finds you well. May I close this issue?

Miguel Aragues · Answer 10 · Sat Aug 08 2015 16:09:34 GMT+0800 (China Standard Time)

This week i may have time, sorry for the delay
El 8/8/2015 0:35, "ahorn" notifications@github.com escribió:

Hi there, I hope this finds you well. May I close this issue?

—
Reply to this email directly or view it on GitHub
#27 (comment).

Miguel Aragues · Answer 11 · Thu Aug 13 2015 18:18:21 GMT+0800 (China Standard Time)

Hi, unfortunately Android Studio does not convert the project
automatically, thus I should devote more time than I can allocate.

Anyway this should be a very straightforward implementation.

You can even use this website that automatically converts a class to
parcelable

http://www.parcelabler.com/

On Sat, Aug 8, 2015 at 11:09 AM, ahorn notifications@github.com wrote:

Cool!

—
Reply to this email directly or view it on GitHub
#27 (comment).

ahorn · Answer 12 · Thu Aug 13 2015 19:03:04 GMT+0800 (China Standard Time)

Thanks for looking into this. I am afraid though I don't have time either. Should I close the issue?

ahorn · Answer 13 · Sun Oct 22 2017 00:26:30 GMT+0800 (China Standard Time)

Hi @Maragues

For some time now, I wanted to update the README with references to projects/products that are using android-rss. If it's okay for this information to be public, I would be grateful if you could share the project name or product (if any) that is using android-rss.

Many thanks in advance.