Fields with reserved Javascript keywords are not prefixed with pb_ in AsObject types

[Bjørn Hald Sørensen]

Protobuf prefixes pb_ to fields with the name of a reserved Javascript keyword when calling the toObject() method, but the generated TypeScript typings Message.AsObject don't seem to take this into account. It's documented in this comment and the list of keywords used is here.

With the following proto file from the examples I've added a function field.

syntax = "proto3";

package com.book;

message Book {
    int64 isbn = 1;
    string title = 2;
    string author = 3;
    string function = 4;
}

The generated Javascript for toObject() becomes the following. Notice the pb_ prefix on the function field.

proto.com.book.Book.toObject = function(includeInstance, msg) {
  var f, obj = {
    isbn: jspb.Message.getFieldWithDefault(msg, 1, 0),
    title: jspb.Message.getFieldWithDefault(msg, 2, ""),
    author: jspb.Message.getFieldWithDefault(msg, 3, ""),
    pb_function: jspb.Message.getFieldWithDefault(msg, 4, "")
  };

  if (includeInstance) {
    obj.$jspbMessageInstance = msg;
  }
  return obj;
};
}

And this is the TypeScript for the return value of toObject():

export namespace Book {
    export type AsObject = {
        isbn: number,
        title: string,
        author: string,
        function: string,
    }
}

I can see that the AsObject type is defined in src/lib/template/partial/message.hbs lines 61 to 81 and I guess it should be trivial to verify each field name against the list of reserved keywords and prefix as necessary before handing the data to the template.

I'll be happy to provide a PR with a fix, but do you handle any other special cases at the moment, so I can make it in the same manner?

[Jonathan Dai]

Sorry for the late reply.

Just merged PR & the latest new version 2.2.5 has been released.

Thank you for your Issue & PR.