React 17 support in peerDeps range
mihkeleidast opened this issue · comments
This module does not currently allow React 17 in it's peerDependency range. Requesting that this would be allowed.
Yea was planning on making that change soon. Should probably work fine with React 17 since it only changes event capture and react-signature-canvas and signature_pad don't rely on React's event capture.
I'll have to update the devDep and make sure tests pass first. Might get to it in the coming week as I've been looking to get back to this library and make some merges I put off.
In any case, it's just a warning, so it should not be a blocker.
Would you accept a PR if everything works? I like to strictly follow peerDependency ranges so this may block our upgrade soon.
Would also be open to lend a hand if needed
Hi, would like to know when the solution will be released. Knowing this will come together with other important fixes but just want to confirm the date.
Now that npm v7 has been released, this is becoming more of a blocker to upgrading. npm@7 throws an error if peerDeps cannot be resolved correctly.
Are we adding support for React 17? I tried to upgrade the react in a fork, but getting some issues running the test after upgrading enzyme.
any quick workaround to make this work on react 17?
edit:
found this compatible version https://www.npmjs.com/package/react-signature-canvas-react17-compatible
@agilgur5 can we get an update on this? Cheers
@agilgur5 It would be nice to have this ASAP
Hi all. I have created an npm package as a workaround for the React 17 issue https://www.npmjs.com/package/react-signature-drawing. This has a direct dependency on this project. This should be used until agilgur5 is back
Any plan when React 17 support will be added?
Released in v1.0.5