Some recent additions to `Data.Nat.Divisibility` use vertical bar rather than dvisibility operator in their names

Question

Some recent additions to `Data.Nat.Divisibility` use vertical bar rather than dvisibility operator in their names

Taneb opened this issue 6 months ago · comments

e.g. m|n⇒n≡quotient*m and m|n⇒n≡m*quotient

It'd be nice if we could have a CI check for this but I don't know how we could do that (can we get agda to list all identifiers or definitions or similar?)

jamesmckinna · Answer 1 · Fri Dec 22 2023 20:34:51 GMT+0800 (China Standard Time)

Apologies if I (unwittingly!!!) introduced these in recent refactoring PRs.
I believed myself to have been consistently using \| as the correct symbol. But it's possible that

it's not the correct symbol (please advise if so! and update the style-guide to disambiguate if necessary?)
I've not been consistent with \... (ditto!)

Nathan van Doorn · Answer 2 · Fri Dec 22 2023 20:41:14 GMT+0800 (China Standard Time)

\| should give the correct symbol. I fear it's the second option that happened - made worse because either my browser's ctrl-F function or GitHub seems to normalise the two symbols so they compare equally, meaning it can be hard to catch this in review.

jamesmckinna · Answer 3 · Tue Dec 26 2023 23:00:38 GMT+0800 (China Standard Time)

Oops! Not a v2.0.1 bug, #2182 was a v2.1 PR...