Modernising `Data.Nat.Properties`

Question

Modernising `Data.Nat.Properties`

jamesmckinna opened this issue 10 months ago · comments

jamesmckinna commented 10 months ago

Two quick thoughts, plus a placeholder:

currently, there is no use of variables !
suc-injective can be made lazier by redefining it as cong pred, and systematically replacing uses of that compound elsewhere?
anything else?

NB this is intended to be cosmetic for v2.0, not the systematic overhaul envisaged by @JacquesCarette in #1925

Note to self: could be folded into any PR addressing #2087

jamesmckinna · Answer 1 · Thu Dec 07 2023 13:56:06 GMT+0800 (China Standard Time)

I'm sure that this sort of issue will recur, but closing this now (and should have, after #2089).

MatthewDaggitt · Answer 2 · Thu Dec 07 2023 14:07:05 GMT+0800 (China Standard Time)

@jamesmckinna when you close issues because a PR has addressed them, can you check that there's the correct Milestone added and the PR is linked against in the Development box (both on the RHS). Makes it a little easier to sort and filter historical issues when doing archaeology!

jamesmckinna · Answer 3 · Wed Dec 13 2023 15:21:55 GMT+0800 (China Standard Time)

Certainly! Sorry to have missed your comment until now.