Goroutine leak?

[Seth Ammons]

Hi!
If a function times out, ala:
https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L160-L165

Then this would block, causing a leaked goroutine:
https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L97

Yeah?

[keith]

thanks for the report. i'll get this addressed and add a test

[cfchou]

Hi @sethgrid,

If I'm reading you right, I believe https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L97 shouldn't block because cmd.finished is a buffered chan.

[Seth Ammons]

Ah, a buffered chan should handle that, as long as the buffer does not fill. :)

[cfchou]

My observation is that cmd.finished doesn't fill. Because cmd is a local variable and is accessed by two goroutines created in the same scope. Only one of them at L97 writes once to cmd.finished.

I hope I don't miss anything though.

[Seth Ammons]

Makes sense; sorry for the false alarm!

…

On Thu, Oct 19, 2017 at 2:36 AM cfchou ***@***.***> wrote: My observation is that cmd.finished doesn't fill. Because cmd is a local variable and is accessed by two goroutines created in the same scope. Only one of them at L97 <https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L97> writes once to cmd.finished. I hope I don't miss anything though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8afIRzFR3kQwlGR2WwBGSIcBBqS5aPks5stwongaJpZM4PbuKI> .

[Alex Simion]

@sethgrid @afex should this issue be closed?

[Seth Ammons]

Yes. I should have done that; my bad!