Giters

afex / hystrix-go

Netflix's Hystrix latency and fault tolerance library, for Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect build instructions

fgm opened this issue · comments

commented

Problem description

With the current "Build and test" instructions in the readme:

  • there is an error on vagrant up because the https://github.com/smartystreets/assertions package now needs Go 1.13 (for errors.Is but the VM provides Go 1.9
  • the go test ./... instructions don't work because /go is root:root but the VM guest user id vagrant:vagrant so the go tool can't download the dependencies
  • when adding a such chown -R vagrant:vagrant /go the go tool downloads success, but the build fails because of https://github.com/smartystreets/assertions dependency on Go 1.13 again.

Suggested changes

  • In the short term, upgrade to Go 1.17 since this is the current version
  • In the longer term convert to docker for ease of use/speed.